Simon Horman <[email protected]> writes: > On Wed, Sep 25, 2024 at 10:39:04PM +0200, Eelco Chaudron wrote: >> >> >> On 25 Sep 2024, at 21:02, Aaron Conole wrote: >> >> > Eelco Chaudron <[email protected]> writes: >> > >> >> This patch adds a new option, --check-authors-file, to the checkpatch >> >> tool to help OVS maintainers check for missing authors in the >> >> AUTHORS.rst file. >> >> >> >> Signed-off-by: Eelco Chaudron <[email protected]> >> >> --- >> >> v2: Fixed partial match, and long argument check. >> > >> > Not sure about it. For example, is it really a problem with the patch >> > if the author doesn't appear? Maybe this could be a different checking >> > utility? I certainly don't think it would be an error in the patch. >> >> It’s not an error in the patch itself, but an error to be resolved >> before we apply it. >> >> As we have to duplicate a lot of infra for a stand-alone tool, and >> this option is not being enabled by default, I feel like it’s ok to >> enhance checkpatch. It also simplifies commiters the workflow, as >> now I can just run ‘checkpatch.py -3 -S -a’. >> >> Anyone else thoughts, feedback on this? > > The approach taken here seems reasonable to me. > Those who have a use for the feature can use checkpatch with > the option enabled, while those who don't won't be effected. > And the implementation can make use of existing infrastructure > in checkpatch.py.
Okay, that makes sense. I'll reply to the original patch with one nit. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
