On 9/27/24 21:27, Aaron Conole wrote: > Ilya Maximets <[email protected]> writes: > >> On 9/27/24 15:41, Eelco Chaudron wrote: >>> >>> >>> On 27 Sep 2024, at 14:51, Aaron Conole wrote: >>> >>>> Eelco Chaudron <[email protected]> writes: >>>> >>>>> Sarif-tools v3.0 introduced an issue that has been resolved in v3.0.1. >>>>> Ensure that v3.0.1 or higher is installed via pip. >>>>> >>>>> Fixes: 234e626198a4 ("ci: Use previous sarif-tools release due to >>>>> issue in latest release.") >>>>> Signed-off-by: Eelco Chaudron <[email protected]> >>>>> --- >>>> >>>> Thanks, Eelco. Applied and backported to branch-3.4 and branch-3.3. >>> >>> Thanks Aaron for applying and doing the backport. >> >> Hi, Eelco and Aaron. There is something wrong with it still. >> >> The check failed on both main and branch-3.4 (3.3 is fine): > > O_O > > Well, I applied based on: > https://github.com/ovsrobot/ovs/actions/runs/11048312854 > > So looks like Sarif recent versions could be unstable, maybe?
Yeah, I did a couple re-runs in my fork and it seem to fail randomly, i.e. one re-run without any code changes can fail or succeed. Should the change be reverted back to 2.0.0 ? Also, sarif-tools>=3.0.1 in a shell command means "re-direct the output to the file named '=3.0.1'", so the patch itself is not correct. Best regards, Ilya Maximets. > >> Check: exiting with return code 2 due to increase in issues at or above note >> severity >> error level: +0 -0 no changes >> warning level: +2 -2 >> New issue "core.NullDereference ..." (36 occurrences) >> file:///home/runner/work/ovs/ovs/include/openvswitch/hmap.h:319 >> file:///home/runner/work/ovs/ovs/include/openvswitch/list.h:262 >> file:///home/runner/work/ovs/ovs/include/openvswitch/nsh.h:287 >> ... >> New issue "core.UndefinedBinaryOperatorResult The left operand of ' ..." >> (4 occurrences) >> file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:946 >> file:///home/runner/work/ovs/ovs/lib/dpif-netdev.c:963 >> file:///home/runner/work/ovs/ovs/lib/netlink-socket.c:240 >> ... >> Eliminated issue "core.NullDereference Access to field ' ..." >> Eliminated issue "core.UndefinedBinaryOperatorResult The ..." >> note level: +0 -0 no changes >> all levels: +2 -2 >> >> Best regards, Ilya Maximets. > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
