On 10 Oct 2024, at 12:33, Ilya Maximets wrote:
> On 10/9/24 22:27, Aaron Conole wrote:
>> Eelco Chaudron <[email protected]> writes:
>>
>>> This patch adds a new option, --check-authors-file, to the checkpatch
>>> tool to help OVS maintainers check for missing authors in the
>>> AUTHORS.rst file.
>>>
>>> Co-authored-by: Aaron Conole <[email protected]>
>>> Signed-off-by: Aaron Conole <[email protected]>
>>> Signed-off-by: Eelco Chaudron <[email protected]>
>>> ---
>>
>> Thanks Eelco - applied.
>
> Hi, Aaron and Eelco.
>
> This change broke CirrusCI:
> https://cirrus-ci.com/task/4643991453433856?logs=check#L3142
>
> 24. checkpatch.at:638: testing checkpatch - AUTHORS.rst existence ...
> ./checkpatch.at:36: $PYTHON3 $top_srcdir/utilities/checkpatch.py $3 -q
> test.patch
> ./checkpatch.at:32: $PYTHON3 $top_srcdir/utilities/checkpatch.py $3 -q
> test.patch
> --- /dev/null 2024-10-09 20:10:11.586373000 +0000
> +++ /tmp/cirrus-ci-build/tests/testsuite.dir/at-groups/24/stderr
> 2024-10-09 20:10:11.585078000 +0000
> @@ -0,0 +1,2 @@
> +/bin/sh: git: not found
> +/bin/sh: git: not found
> stdout:
> ERROR: Could not open AUTHORS.rst in './'!
> Lines checked: 4, Warnings: 0, Errors: 1
> ovsdb-server.log:
> sed: ovsdb-server.log: No such file or directory
> ovs-vswitchd.log:
> sed: ovs-vswitchd.log: No such file or directory
> 24. checkpatch.at:638: 24. checkpatch - AUTHORS.rst existence
> (checkpatch.at:638): FAILED (checkpatch.at:32)
>
>
> Could you please check?
> In general, we should not require git to run unit tests.
Will take a look. Thought I ran it through CirrusCI :(
//Eelco
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
