Apologies, I sent this last week but failed at reply-to-all.
Definitely a needed fix, thanks!

On Tue, Oct 1, 2024 at 4:21 AM Luca Czesla via dev
<[email protected]> wrote:
> @@ -53,7 +53,8 @@ class MultiColumnIndex(object):
>      def index_entry_from_row(self, row):
>          return row._table.rows.IndexEntry(
>              uuid=row.uuid,
> -            **{c.column: getattr(row, c.column) for c in self.columns})
> +            **{c.column: row.get_column(c.column, self._uuid_to_uuid)
> +                for c in self.columns})

Here, instead of doing the modification to ovs.db.idl code and adding
the _uuid_to_uuid method, can't we just do:

-            **{c.column: getattr(row, c.column) for c in self.columns})
+            **{c.column: idl._row_to_uuid(getattr(row, c.column))
+               for c in self.columns})

It seemed to work in my local tests. Also, I think we should add a
test case just to make sure this case doesn't get broken in the
future.

Terry

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to