On 10/16/24 15:45, Mark Michelson wrote:
On 10/10/24 12:22, Aaron Conole wrote:
Michał Nasiadka <[email protected]> writes:
It was just my first patch and didn’t know what I should do with those
robot posted failures (basically missing signed-off-by).
What should I do now to get that moved forward please?
It would be best to repost (v2) with the correct signed-off-by line, I
think. Replying with a new signoff will have patchwork include both.
But an OVN maintainer may have a different opinion.
Aaron is correct here. To send a new version, send a new email with "v2"
in the subject line:
[PATCH ovn v2] ovn-ctl: Add run_sb_relay_ovsdb_subcommand
That's the typical way to get a new version of a patch posted, whether
due to review comments or because the bot spots something that breaks
guidelines.
Now, having said that, this is a small patch, so I think we can skip all
that this time.
Acked-by: Mark Michelson <[email protected]>
I'll make sure the sign-off is correct and get this merged. Thanks for
contributing!
I pushed this to main. Thanks again!
Best regards,
Michal
On 27 Sep 2024, at 21:49, Aaron Conole <[email protected]> wrote:
Michał Nasiadka <[email protected]> writes:
This patch adds missing subcommand for running SB Relay in foreground.
Signed-off-by: Michał Nasiadka <[email protected]>
---
Seems these were done as top-post replied to the robot. Was there any
reason why?
utilities/ovn-ctl | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
index d7ca9e758..c0b797273 100755
--- a/utilities/ovn-ctl
+++ b/utilities/ovn-ctl
@@ -499,6 +499,11 @@ run_sb_ovsdb() {
start_sb_ovsdb
}
+run_sb_relay_ovsdb() {
+ DB_SB_RELAY_DETACH=no
+ start_sb_relay_ovsdb
+}
+
run_ic_nb_ovsdb() {
DB_IC_NB_DETACH=no
start_ic_nb_ovsdb
@@ -1469,6 +1474,9 @@ case $command in
run_sb_ovsdb)
run_sb_ovsdb
;;
+ run_sb_relay_ovsdb)
+ run_sb_relay_ovsdb
+ ;;
run_ic_nb_ovsdb)
run_ic_nb_ovsdb
;;
--
2.34.1
On 11 Sep 2024, at 14:51, Michał Nasiadka <[email protected]> wrote:
This patch adds missing subcommand for running SB Relay in foreground.
Signed-off-by: Michał Nasiadka <[email protected]>
---
utilities/ovn-ctl | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/utilities/ovn-ctl b/utilities/ovn-ctl
index d7ca9e758..c0b797273 100755
--- a/utilities/ovn-ctl
+++ b/utilities/ovn-ctl
@@ -499,6 +499,11 @@ run_sb_ovsdb() {
start_sb_ovsdb
}
+run_sb_relay_ovsdb() {
+ DB_SB_RELAY_DETACH=no
+ start_sb_relay_ovsdb
+}
+
run_ic_nb_ovsdb() {
DB_IC_NB_DETACH=no
start_ic_nb_ovsdb
@@ -1469,6 +1474,9 @@ case $command in
run_sb_ovsdb)
run_sb_ovsdb
;;
+ run_sb_relay_ovsdb)
+ run_sb_relay_ovsdb
+ ;;
run_ic_nb_ovsdb)
run_ic_nb_ovsdb
;;
--
2.34.1
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
