Mike Ovsiannikov <[email protected]> writes:

> Initialize learn_adds_rule in order to prevent
> crash in ofproto_flow_mod_learn_finish() due to
> being invoked with uninitialized rules
> collections.
>
> Signed-off-by: Mike Ovsiannikov <[email protected]>
>
> ---

Hi Mike,

I think this should have:

Fixes: 1f4a89336682 ("ofproto: Refactor packet_out handling.")

Also, I don't see many details on how we have uninitialized rules
collections.  Is it possible to include a stack trace / steps to
reproduce the problem?  Could it be that there is a race somewhere?
Is it during add/remove of some group?  We shouldn't get into this case
without at least a valid rule, I think (at least it seems like all paths
need to cross the XC_LEARN / or a learn xlate test).

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to