On 11/4/24 16:45, Lorenzo Bianconi wrote:
> Always use check with ovn-nbctl --wait={hv,sb} wherever possible
> 
> Reported-at: https://issues.redhat.com/browse/FDP-875
> Signed-off-by: Lorenzo Bianconi <[email protected]>
> ---
>  tests/ovn-controller.at  |  10 +--
>  tests/ovn-ic.at          |   2 +-
>  tests/ovn-northd.at      |  56 ++++++------
>  tests/ovn-performance.at |   2 +-
>  tests/ovn.at             | 190 +++++++++++++++++++--------------------
>  tests/perf-northd.at     |   4 +-
>  tests/system-ovn-kmod.at |   4 +-
>  tests/system-ovn.at      | 126 +++++++++++++-------------
>  8 files changed, 197 insertions(+), 197 deletions(-)

Hi, Lorenzo.  Thanks for the patch!
 
But why only the sync commands?  I think all the ctl commands should be
checked.  If any of nb/sb-ctl commands fail unexpectedly, the meaning of
the test can change and we may also not really test what was intended in
the test scenario.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to