Hi Lorenzo Thanks for the patches. I have one general question about them: would it be possible to split them somehow differently, and have the additions of "check" in a (serie of) patches, and another patch containing the fixes to the test (i.e. the test that were failing, were identified by the check addition and were fixed by you). I am not sure whether the maintainers will backport the patches related to the check addition (it might be painful). But backporting the fixes themselves would be more useful I think. Also, I think we should modify the utilities/checkpatch so that it ... checks ... that "check" is added to ovn-nbctl/sbctl commands when possible, so reviewers do not have to do that anymore. WDYT? Thanks Xavier
On Tue, Nov 5, 2024 at 8:23 PM Lorenzo Bianconi <[email protected]> wrote: > Reported-at: https://issues.redhat.com/browse/FDP-875 > > Lorenzo Bianconi (8): > test: ovn-controller: Use check for ovn-nbctl wherever possible. > test: system-ovn: Use check for ovn-nbctl wherever possible. > test: ovn: Use check for ovn-nbctl wherever possible. > test: ovn-northd: Use check for ovn-nbctl wherever possible. > test: ovn-performance: Use check for ovn-nbctl wherever possible. > test: ovn-ic: Use check for ovn-nbctl wherever possible. > test: perf-northd: Use check for ovn-nbctl wherever possible. > test: Use check for ovn-sbctl wherever possible. > > tests/ovn-controller.at | 32 +- > tests/ovn-ic.at | 52 +- > tests/ovn-northd.at | 943 ++++++----- > tests/ovn-performance.at | 6 +- > tests/ovn.at | 3272 +++++++++++++++++++------------------- > tests/perf-northd.at | 4 +- > tests/system-ovn-kmod.at | 306 ++-- > tests/system-ovn.at | 1889 +++++++++++----------- > 8 files changed, 3251 insertions(+), 3253 deletions(-) > > -- > 2.47.0 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
