On 11/4/24 12:09, Lorenzo Bianconi wrote: > Set HTB Qdisc scheduler root max-rate according to the reported > link-speed if it is available (use default value if the link_speed is > not reported by OvS). This patch allows more precise shaping when the > NIC speed is lower than 34Gbps (current default value) and even take into > account cases where NIC capacity is greater than 34 Gbps.
Could you, please, describe the problem in more details, i.e. why the shaping is not precise with the current code? This information is essential in the commit message. Also, there is a large comment above add_ovs_qos_table_entry() function about link speed not being reliable at least for virtual ports. This comment will need an adjustment, but also this patch will unnecessarily limit the speed of all the veth and tap interfaces in OVN. We need a way to avoid that. Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
