On Thu, Oct 31, 2024 at 03:13:38PM +0800, Allen Chen via dev wrote:
> Support icmpv6 offload
>
> Signed-off-by: Allen Chen <[email protected]>
Hi Allen,
The code you have added looks correct to me.
However, I believe that more code is needed to support this offload.
1. I think the following condition, also in parse_flow_match,
needs to be updated:
if (proto != IPPROTO_ICMP && proto != IPPROTO_UDP &&
proto != IPPROTO_SCTP && proto != IPPROTO_TCP &&
(match->wc.masks.tp_src ||
match->wc.masks.tp_dst ||
match->wc.masks.tcp_flags)) {
VLOG_DBG("L4 Protocol (%u) not supported", proto);
return -1;
}
2. I think that handling of RTE_FLOW_ITEM_TYPE_ICMP6
needs to be added to dump_flow_pattern().
I also think it would be good to update ./NEWS.
And, lastly, as I unfortunately do not have an easy way to test this,
I'd appreciate it if the commit message could include some logs showing
usage of this new feature.
Thanks!
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
