Bleep bloop. Greetings Max Lamprecht, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Improper whitespace around control block
#163 FILE: controller/ovn-controller.c:3487:
SSET_FOR_EACH(gw_port, local_l3gw_ports) {
ERROR: Improper whitespace around control block
#311 FILE: controller/ovn-controller.c:3635:
SHASH_FOR_EACH(nat_node, &nat_addresses->nat_addresses) {
WARNING: Line is 97 characters long (recommended limit is 79)
#324 FILE: controller/ovn-controller.c:3648:
&nat_addresses->localnet_vifs,
&nat_addresses->local_l3gw_ports);
WARNING: Line is 93 characters long (recommended limit is 79)
#327 FILE: controller/ovn-controller.c:3651:
&nat_addresses->nat_ip_keys,
&nat_addresses->local_l3gw_ports,
WARNING: Line is 91 characters long (recommended limit is 79)
#382 FILE: controller/ovn-controller.c:5463:
engine_add_input(&en_nat_addresses, &en_sb_port_binding,
nat_addresses_change_handler);
WARNING: Line is 88 characters long (recommended limit is 79)
#383 FILE: controller/ovn-controller.c:5464:
engine_add_input(&en_nat_addresses, &en_runtime_data,
nat_addresses_change_handler);
WARNING: Line is 81 characters long (recommended limit is 79)
#838 FILE: controller/pinctrl.c:6251:
if (pb && !smap_get_bool(&pb->options, "disable_garp_rarp", false))
{
WARNING: Line is 87 characters long (recommended limit is 79)
#841 FILE: controller/pinctrl.c:6254:
local_datapaths, pb,
&nat_addresses->nat_addresses,
WARNING: Line is 81 characters long (recommended limit is 79)
#856 FILE: controller/pinctrl.c:6265:
if (pb && !smap_get_bool(&pb->options, "disable_garp_rarp", false))
{
WARNING: Line is 83 characters long (recommended limit is 79)
#857 FILE: controller/pinctrl.c:6266:
send_garp_rarp_update(ovnsb_idl_txn,
sbrec_mac_binding_by_lport_ip,
WARNING: Line is 87 characters long (recommended limit is 79)
#858 FILE: controller/pinctrl.c:6267:
local_datapaths, pb,
&nat_addresses->nat_addresses,
Lines checked: 930, Warnings: 9, Errors: 2
Please check this out. If you feel there has been an error, please email
[email protected]
Thanks,
0-day Robot
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
