On Tue, Nov 12, 2024 at 01:26:56PM +0100, Paolo Valerio wrote: > On Tue, Nov 12, 2024 at 12:07 AM Aaron Conole <[email protected]> wrote: > > > > Paolo Valerio <[email protected]> writes: > > > > > Simon Horman <[email protected]> writes: > > > > > >> Hi, > > >> > > >> This series aims to update the testsuite so that, if available, > > >> nft is used in palce of iptables. The motivation being to move > > >> to more modern tooling. > > >> > > >> --- > > > > > > Hi Simon, > > > > Hi Paolo, > > > > > The patches look good, I also performed some tests and things work as > > > expected. > > > > > > I noticed that "datapath - ping over erspan v1 tunnel by simulated > > > packets" still uses IPTABLES_ACCEPT(). > > > > > > Also, "datapath - ping over erspan v2 tunnel by simulated packets" does > > > not use the macro, but directly uses iptables with the ACCEPT target > > > > > > These last two also: > > > datapath - ping over ip6erspan v1 tunnel by simulated packets > > > datapath - ping over ip6erspan v2 tunnel by simulated packets > > > > > > instead, do the same but for v6 (ip6tables). > > > They went unnoticed while adding $HAVE_IPTABLES. > > > > > > I guess those should be handled in this set as well. > > > WDYT? > > > > Sorry - I didn't see your comment when doing the apply (my tool didn't > > pull the cover letter comments). I guess this should be done as a follow > > up. > > No worries. > Yes, a follow-up will work.
Likewise, sorry for the slow response. I'll work on a follow-up patch for this. ... _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
