Hello, Martin,

Thank you for working on this!

On Wed, Nov 27, 2024 at 1:55 PM Martin Kalcok
<[email protected]> wrote:
>
> Hi all,
> We are interested in the ability to route IPv4 traffic over
> IPv6 next hop addresses, as it ties into our plans for BGP integration,
> specifically for the BGP Unnumbered. We believe that Felix's original series
> came very close to making it happen, the only issue was the register 
> corruption
> discovered by Numan in the v2 code review.
> We believe that this could be fixed by moving REG_SRC_IPV4 to a different,
> unused, register (see more info in the commit message).
>
> v2 -> v3 changes:
>   * Added patch that moves REG_SRC_IPV4 from reg1 to reg5
>   * Original series rebased on top of current main + merge conflict 
> resolutions
>   * Adjusted unit tests for the original patches to pass
>     * On account of the test changes that were more than just merge conflict 
> resolutions,
>       I added myself as a co-author to one of the commits originally authored 
> by Felix.
>
>
> Felix Huettner (2):
>   northd: Handle routing for other address families.
>   pinctrl: Handle arp/nd for other address families.
>
> Martin Kalcok (1):
>   northd: move REG_SRC_IPV4 from reg1 to reg5

It is important to keep the git history bisectable, and knowing that
the first two patches of this series introduce a register corruption
bug, would it not be pertinent to reorder the patches?

--
Frode Nordahl

>  NEWS                  |   4 +
>  controller/pinctrl.c  |  52 ++-
>  lib/actions.c         |   4 +-
>  northd/northd.c       | 104 ++---
>  northd/northd.h       |   2 +
>  tests/ovn-nbctl.at    |  26 +-
>  tests/ovn-northd.at   | 168 +++++---
>  tests/ovn.at          | 915 +++++++++++++++++++++++++++++++++++++++++-
>  utilities/ovn-nbctl.c |  12 +-
>  9 files changed, 1162 insertions(+), 125 deletions(-)
>
> --
> 2.43.0
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to