On Thu, Nov 14, 2024 at 2:50 AM Ales Musil <[email protected]> wrote: > > Some of the NB rows has only one corresponding row in SB, we can > reuse the UUID from NB for the SB row. This makes it easier to handle > changes as we can directly get the corrsponding row by UUID and is also > better for debugging, because the relation is obvious right away. > > There is still potential to do the same for Datapath_Binding and > Port_Binding tables in SB. In order to have those we would need > some form of collision detection as UUIDs are unique per table. > In theory you could have LS and LR with the same UUID which would > collide at the SB level when we try to do the mapping. The benefit of > of disallowing duplicates across LR and LS, LSP and LRP would be > slightly decresed complexity of the northd code that keeps track of > the relation. > > Ales Musil (5): > northd: Use the same UUID for SB representation of Static_Mac_Binding. > northd: Use the same UUID for SB representation of > Chassis_Template_Var. > northd: Use the same UUID for SB representation of DNS. > northd: Use the same UUID for SB representation of Mirror. > northd: Use the same UUID for SB representation of Load_Balancer.
Thanks for addressing the review comments. I went ahead and applied this patch series to main. Numan > > controller/ovn-dns.c | 145 +++++++++++++++++---------------- > lib/automake.mk | 2 - > lib/static-mac-binding-index.c | 43 ---------- > lib/static-mac-binding-index.h | 27 ------ > northd/en-northd.c | 4 - > northd/en-sync-sb.c | 80 +++--------------- > northd/en-sync-sb.h | 2 - > northd/inc-proc-northd.c | 10 +-- > northd/northd.c | 130 +++++++++++------------------ > northd/northd.h | 1 - > tests/ovn-northd.at | 15 +++- > 11 files changed, 151 insertions(+), 308 deletions(-) > delete mode 100644 lib/static-mac-binding-index.c > delete mode 100644 lib/static-mac-binding-index.h > > -- > 2.47.0 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
