On 11/28/24 8:37 PM, Ilya Maximets wrote:
> Statically allocated datum objects should be properly initialized with
> a special function instead of doing that manually.
>
> WARNING: MemorySanitizer: use-of-uninitialized-value
> 0 0x58789c in ovsdb_datum_compare_3way lib/ovsdb-data.c:1846:19
> 1 0x52bbab in evaluate_relop lib/db-ctl-base.c:731:16
> 2 0x52b042 in check_condition lib/db-ctl-base.c:844:22
> 3 0x522fea in cmd_wait_until lib/db-ctl-base.c:1935:22
> 4 0x4c704b in do_vsctl utilities/ovs-vsctl.c:3001:13
> 5 0x4c4429 in main utilities/ovs-vsctl.c:204:17
> 6 0x7f5ad5 in __libc_start_call_main
> 7 0x7f5ad5 in __libc_start_main@GLIBC_2.2.5
> 8 0x432b04 in _start (utilities/ovs-vsctl+0x432b04)
>
> In this case the reference counter ended up not initialized.
>
> While at it, also updating the list_record() function to use a proper
> initialization, even if it doesn't cause any issues for now.
>
> Fixes: 485ac63d10f8 ("ovsdb: Add lazy-copy support for ovsdb_datum objects.")
> Signed-off-by: Ilya Maximets <[email protected]>
> ---
Looks good to me, thanks!
Acked-by: Dumitru Ceara <[email protected]>
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
