On 11/29/24 14:46, Eelco Chaudron wrote: > > > On 29 Nov 2024, at 13:38, Eelco Chaudron wrote: > >> On 29 Nov 2024, at 13:28, Ilya Maximets wrote: >> >>> On 11/29/24 13:11, Eelco Chaudron wrote: >>>> >>>> >>>> On 12 Nov 2024, at 15:01, Eelco Chaudron wrote: >>>> >>>>> Version history: >>>>> >>>>> v2: - Updated documentation, removed dependency for wget >>>>> - Changed independend curls calls with macros >>>>> - Removed dependancy from ci >>>>> >>>>> Eelco Chaudron (2): >>>>> system-traffic: Replace wget with curl for negative and ftp tests. >>>>> system-traffic: Standardize by replacing all wget instances with curl. >>>>> >>>> >>>> Thanks for the reviews. I’ve applied this to main to start with. >>>> Simon/Ilya, >>>> do think I should backport this, if so, how far back (and both patches)? >>> >>> Thanks, Eelco! >>> >>> I think, it would be good to have both down to 3.3. Otherwise, backporting >>> test changes might be hard in the future. Older branches do not have that >>> much support time left. They also do not run system tests in CI. >> >> Thanks, will commit once tests are completed. > > Tests passed and pushed to the 3.3 and 3.4 branches. >
Unfortunately, this patch set broke the testsuite with a few syntax errors and tests are not actually running: https://github.com/openvswitch/ovs/actions/runs/12084460716/job/33699718393#step:13:2726 I sent a patch to fix the issues here: https://patchwork.ozlabs.org/project/openvswitch/patch/[email protected]/ Please, take a look. Also, we use curl for TFTP calls, should we replace those with a macro as well and remove the CURL_OPT variable? Best regards, Ilya Maximets. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
