On 5 Dec 2024, at 13:25, David Marchand wrote:

> By assuming that OVS maintainers never push changes that breaks
> compilation in GHA (which seems to be the case so far), it seems natural
> to assume that generating the reference for clang analyzer should always
> work.
>
> If generating this reference fails, it is likely due to a change external
> to OVS code, and not due to the series being tested (though this series
> gets flagged with an error in patchwork).
>
> Such a situation is often hit in the dpdk-latest branch when some DPDK
> API change breaks OVS compilation and no OVS fix is merged yet.
>
> Split the clang analyzer check in two jobs:
> - a clang-analyze-cache job, responsible for computing a cache key of the
>   reference code and compiling a reference build,
> - a clang-analyze job, which depends on the former job, responsible for
>   compiling the current patch and comparing the result against the
>   reference,
>
> The cache generation won't be reported as a failure at the OVS build step
> (using continue-on-error:).
> If such a failure happens, the cache-analyze job is skipped.
>
> Fixes: d662eee09724 ("ci: Add clang-analyze to GitHub actions.")
> Signed-off-by: David Marchand <[email protected]>

Patch was applied to master. Will backport this down to 3.3 later this week.

//Eelco

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to