On Fri, Dec 13, 2024 at 4:07 AM fangjiannan <[email protected]> wrote: > > From: fang <[email protected]> > > Canceling packet copying can better improve the performance of capturing > fragmented packets. In 640d4db, pkt copying was added to fix the crash, but > this bug has been fixed in 7e6b41a, so there is no need to copy the pkt again. > > Signed-off-by: fangjiannan <[email protected]>
The CI is looking for an exact match with the from line, eg: Signed-off-by: fang <[email protected]> But I think the sign off tag and commit message line wrap can just be corrected as the patch is applied. Code still looks good. Acked-by: Mike Pattrick <[email protected]> > --- > lib/ipf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/ipf.c b/lib/ipf.c > index 2d715f5e9..59e232355 100644 > --- a/lib/ipf.c > +++ b/lib/ipf.c > @@ -820,7 +820,7 @@ ipf_process_frag(struct ipf *ipf, struct ipf_list > *ipf_list, > * recommend not setting the mempool number of buffers too low > * and also clamp the number of fragments. */ > struct ipf_frag *frag = &ipf_list->frag_list[last_inuse_idx + 1]; > - frag->pkt = dp_packet_clone(pkt); > + frag->pkt = pkt; > frag->start_data_byte = start_data_byte; > frag->end_data_byte = end_data_byte; > ipf_list->last_inuse_idx++; > @@ -959,7 +959,6 @@ ipf_extract_frags_from_batch(struct ipf *ipf, struct > dp_packet_batch *pb, > dp_packet_batch_refill(pb, rp->pkt, pb_idx); > rp->list->reass_execute_ctx = rp->pkt; > } > - dp_packet_delete(pkt); > } > ovs_mutex_unlock(&ipf->ipf_lock); > } else { > -- > 2.42.0.windows.2 > > _______________________________________________ > dev mailing list > [email protected] > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
