On 12/17/24 4:25 PM, Dumitru Ceara wrote: > On 12/4/24 4:10 PM, Martin Kalcok wrote: >> From: Felix Huettner <[email protected]> >> >> Previously we could only generate ARP requests from IPv4 packets >> and NS requests from IPv6 packets. This was the case because we rely on >> information in the packet to generate the ARP/NS requests. >> >> However in case of ARP/NS requests originating from the Logical_Router >> pipeline for nexthop lookups we overwrite the affected fields >> afterwards. This overwrite is done by the userdata openflow actions. >> Because of this we actually do not rely on any information of the IPv4/6 >> packets in these cases. >> >> Unfortunately we can not easily determine if we are actually later >> overwriting the affected fields. The approach now is to use the fields >> from the IP header if we have a matching IP version and default to some >> values otherwise. In case we overwrite this data afterwards we are >> generally good. If we do not overwrite this data because of some bug we >> will send out invalid ARP/NS requests. They will hopefully be dropped by >> the rest of the network. >> >> The alternative would have been to introduce new arp/nd_ns actions where >> we guarantee this overwrite. This would not suffer from the above >> limitations, but would require a coordination on upgrades between all >> ovn-controllers and northd. >> >> Signed-off-by: Felix Huettner <[email protected]> >> Signed-off-by: Martin Kalcok <[email protected]> >> Co-authored-by: Martin Kalcok <[email protected]> >> --- > > Thanks, Felix and Martin! This looks good to me. I only had a few > minor comments (see inline) but I can take care of those when applying > the patch to main. > > Just as for patch 2/3, you can find the rebased version here: > https://github.com/dceara/ovn/commits/bcba1b74 > > I'll wait for confirmation that it still looks OK before pushing the > series to main. >
Applied to main (as discussed on patch 2/3). Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
