On 12/20/24 10:31 PM, Numan Siddique wrote: > On Thu, Nov 14, 2024 at 8:58 AM Xavier Simonart <[email protected]> wrote: >> Signed-off-by: Xavier Simonart <[email protected]> >> --- >> controller/physical.c | 15 ++++++++++++--- >> 1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/controller/physical.c b/controller/physical.c >> index 8d5065098..6b93696fa 100644 >> --- a/controller/physical.c >> +++ b/controller/physical.c >> @@ -2194,15 +2194,15 @@ consider_mc_group(struct ovsdb_idl_index >> *sbrec_port_binding_by_name, >> } >> >> int zone_id = ct_zone_find_zone(ct_zones, port->logical_port); >> - if (zone_id) { >> - put_load(zone_id, MFF_LOG_CT_ZONE, 0, 16, &ofpacts); >> - } > Hi Xavier, > > I'm a little confused with this patch. Can you please explain what is > the improvement here ? > > Also can you please update the commit message with more details ? > > From what I understand prior to this patch, for all the port bindings > in a multicast group, > zone id of the pb (if present) is loaded to the ct_zone register. > > How is this patch avoiding setting the same register again ? > > Thanks > Numan
Hi Numan, Xavier, I marked the rest of the series as "changes requested" in patchwork. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
