On 1/10/25 18:35, Ilya Maximets wrote:
> On 1/9/25 12:35, Roi Dayan wrote:
>> From: Gaetan Rivet <[email protected]>
>>
>> Count the number of updates done (insertion + deletion) to each caches.
>>
>> Signed-off-by: Gaetan Rivet <[email protected]>
>> Acked-by: Roi Dayan <[email protected]>
>> ---
> 
> Hmm.  What's the point of counting if these counters are never read?
> 

Also, did you run some kind of performance testing to see if these
counters affect performance in any way?  They are all on a hot path,
so performance evaluation is necessary.  We'll need at least a few
words about performance impact in the commit messages.

> Best regards, Ilya Maximets.

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to