On Fri, Jan 3, 2025 at 1:00 PM Ilya Maximets <[email protected]> wrote:
>
> On 12/19/24 11:53, Frode Nordahl wrote:
> > As a courtesy to users building artifacts from debs, don't pull
> > in Python when not necessary.
> >
> > Interactive UX is retained because apt-get will install
> > dependencies decleared as recommended by default.
> >
> > Signed-off-by: Frode Nordahl <[email protected]>
>
> Not a problem of this patch, but I see that build complains (with or without
> the patch set) that python3:Depends is used but not defined. Do you know if
> it is something we need to fix?
These appear to be printed on the back of having the macro present on
the openvswitch-vtep "binary" package, which does not actually have
Python3 code that would generate extra dependencies. I'll add a patch
that removes it.
While at it, a similar warning is printed for openvswitch-ipsec for
shlibs:Depends, because it does not actually contain any binaries
subject to shared libraries.
--
Frode Nordahl
> Best regards, Ilya Maximets.
>
> > ---
> > debian/control.in | 11 ++++++-----
> > 1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/debian/control.in b/debian/control.in
> > index 6737672d1..958eec3a2 100644
> > --- a/debian/control.in
> > +++ b/debian/control.in
> > @@ -45,8 +45,9 @@ Architecture: linux-any
> > Depends:
> > openssl,
> > ${misc:Depends},
> > - ${python3:Depends},
> > ${shlibs:Depends},
> > +Recommends:
> > + ${python3:Depends},
> > Suggests:
> > ethtool,
> > openvswitch-doc,
> > @@ -154,12 +155,13 @@ Depends:
> > netbase,
> > openvswitch-common (= ${binary:Version}),
> > procps,
> > - python3-netifaces,
> > - python3-openvswitch (>= ${source:Version}),
> > uuid-runtime,
> > ${misc:Depends},
> > - ${python3:Depends},
> > ${shlibs:Depends},
> > +Recommends:
> > + python3-netifaces,
> > + python3-openvswitch (>= ${source:Version}),
> > + ${python3:Depends},
> > Breaks:
> > openvswitch-common (<< 2.17~),
> > Replaces:
> > @@ -183,7 +185,6 @@ Description: Open vSwitch switch implementations
> > # DPDK_NETDEV dpdk,
> > # DPDK_NETDEV openvswitch-switch (= ${binary:Version}),
> > # DPDK_NETDEV ${misc:Depends},
> > -# DPDK_NETDEV ${python3:Depends},
> > # DPDK_NETDEV ${shlibs:Depends},
> > # DPDK_NETDEV Enhances:
> > # DPDK_NETDEV openvswitch-switch,
>
> _______________________________________________
> dev mailing list
> [email protected]
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
