Re: [ovs-dev] [PATCH v6 09/16] route-table: Use RTA_TABLE for route table filter.

[Eelco Chaudron]

On 13 Jan 2025, at 21:45, Frode Nordahl wrote:

> The rtnetlink rtmsg rtm_table variable can hold route table IDs no
> higher than UCHAR_MAX.
>
> Use the rtnetlink RTA_TABLE route attribute for table IDs larger
> than UCHAR_MAX, which can represent a 32 bit integer worth of
> route tables.
>
> While RTA_TABLE support was added to the kernel in commit [0] and
> has been supported since 2006 starting from v2.6.19, we retain
> a backward compatible approach for consistency with the existing
> code for reading route table back from the kernel [1].
>
> 0: 
> https://github.com/torvalds/linux/commit/9e762a4a89b302cb3b26a1f9bb33eff459eaeca9
> 1: 
> https://github.com/openvswitch/ovs/blob/8b7f1eb8db1aa99ccf7b542662129450caff65e0/lib/route-table.c#L284-L287
> Signed-off-by: Frode Nordahl <fnord...@ubuntu.com>

Thanks for the changes. This patch looks good to me.

Acked-by: Eelco Chaudron <echau...@redhat.com>

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev