On 13 Jan 2025, at 21:45, Frode Nordahl wrote:
> Note that the internal handling of routes in the ovs-route module > does currently not support multipath routes, so when presented > with one the first occurrence will be stored. This is not a > regression as these routes were previously not considered at all. > > Storing the information in the route-table module data structure > will allow external to OVS projects make use of this data. > > A test program run as part of the system tests that exercise the > route table API is added in this patch. > > Co-Authored-by: Felix Huettner <[email protected]> > Signed-off-by: Felix Huettner <[email protected]> > Signed-off-by: Frode Nordahl <[email protected]> I have one comment question below. The rest of the patch looks fine. In an earlier patch the following code was added: if (attrs[RTA_VIA]) { const struct rtvia *rtvia = nl_attr_get(attrs[RTA_VIA]); ovs_be32 addr; if (attrs[RTA_GATEWAY]) { VLOG_DBG_RL(&rl, "route message can not contain both " "RTA_GATEWAY and RTA_VIA"); goto error_out; } I’m wondering how this is related to RTA_MULTIPATH. What combinations with RTA_MULTIPATH are valid/invalid, and need checks like this added? Cheers, Eelco <SNIP> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
