On 1/16/25 16:54, David Marchand wrote:
> On Thu, Jan 16, 2025 at 6:22 AM Mike Pattrick <[email protected]> wrote:
>>
>> Previously support for tunnels was added to userspace TSO. However, the
>> documentation was not updated appropriately. This patch adds VxLAN and
>> Geneve as supported tunnels.
>>
>> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
>> Signed-off-by: Mike Pattrick <[email protected]>
> 
> The patch looks good, I would just drop the GRE in the commit title,
> so the title becomes:
> docs: Add tunnel support to TSO documentation.

Ugh.  Sorry, missed that comment.

> 
> This can be fixed when applying.
> Acked-by: David Marchand <[email protected]>

Thanks, Mike and David!  Applied the set and backported the first
patch down to 3.3.

I'm not particularly happy with removal of the kernel version checks
from the tests.  I think, that should be revisited and done more
accurately across other related tests as well.  The check was initially
related to the compat version of the kernel module, so it is indeed
many not be needed today, since we dropped the OOT module support,
however, I'm not sure if the remaining CHECK_GRE() macro covers all
the cases.

Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to