On 1/17/25 1:45 PM, Ilya Maximets wrote: > On 11/29/24 12:36, Lorenzo Bianconi wrote: >> Set HTB Qdisc scheduler root max-rate according to the reported >> link-speed if it is available (use default value if the link_speed is >> not reported by OvS). This patch allows more precise shaping when the >> NIC speed is lower than 34Gbps (current default value) and even take into >> account cases where NIC capacity is greater than 34 Gbps. >> However, rely on default value for veth and tap interfaces since the >> reported link speed is not accurate in this case. >> >> Signed-off-by: Lorenzo Bianconi <[email protected]> >> --- >> Changes since v1: >> - use default max-rate value for veth and tap interfaces >> --- >> controller/binding.c | 20 ++++++++++++++++---- >> controller/ovn-controller.c | 1 + >> 2 files changed, 17 insertions(+), 4 deletions(-) >> >> diff --git a/controller/binding.c b/controller/binding.c >> index 117d0ff5d..7371ac433 100644 >> --- a/controller/binding.c >> +++ b/controller/binding.c >> @@ -244,6 +244,7 @@ add_or_del_qos_port(const char *ovn_port, bool add) >> static bool >> add_ovs_qos_table_entry(struct ovsdb_idl_txn *ovs_idl_txn, >> const struct ovsrec_port *port, >> + const struct ovsrec_interface *iface, >> unsigned long long min_rate, >> unsigned long long max_rate, >> unsigned long long burst, >> @@ -262,7 +263,18 @@ add_ovs_qos_table_entry(struct ovsdb_idl_txn >> *ovs_idl_txn, >> qos = ovsrec_qos_insert(ovs_idl_txn); >> ovsrec_qos_set_type(qos, OVN_QOS_TYPE); >> ovsrec_port_set_qos(port, qos); >> - smap_add_format(&other_config, "max-rate", "%lld", >> OVN_QOS_MAX_RATE); > > I'd add an empty line here. May probably be added on commit. > > > >> + const char *drv_name = smap_get_def(&iface->status, "driver_name", >> ""); >> + /* Link speed for virtual interfaces (e.g. veth or tap is inaccurate >> + * so use default value for them while rely on link speed for real >> + * NICs. */ > > The ')' and a comma before 'so' are missing. > > I assume, comments above can be fixed on commit. > > With that: > Acked-by: Ilya Maximets <[email protected]> >
Thanks, Lorenzo and Ilya! I took care of fixing up the small issues Ilya pointed out above and then I applied the patch to main, 24.09 and 24.03. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
