On Wed, Jan 22, 2025 at 09:29:21AM +0100, Dumitru Ceara wrote: > On 1/22/25 1:34 AM, Numan Siddique wrote: > > On Thu, Jan 16, 2025 at 8:27 AM Dumitru Ceara <dce...@redhat.com> wrote: > >> > >> On 1/15/25 12:13 PM, Dumitru Ceara wrote: > >>> On 1/2/25 4:19 PM, Felix Huettner via dev wrote: > >>>> Hi everyone, > >>>> > >>>> this is the ovn-controller part of the OVN Fabric integration series > >>>> https://mail.openvswitch.org/pipermail/ovs-dev/2024-November/418554.html. > >>>> > >>>> By the end of the series ovn-controller can announce routes from the > >>>> sb Advertised_Route table by writing them to a linux vrf. > >>>> Ovn-controller can also learn routes by reading them from the linux vrf > >>>> and > >>>> writing them to the sb Learned_Route table. > >>>> > >>>> This patch series has two prerequisites and will therefor probably fail > >>>> CI > >>>> tests for now. Therefor i marked this series as RFC. > >>>> > >>>> One prerequisite is including Frodes changes in the ovs submodule: > >>>> https://patchwork.ozlabs.org/project/openvswitch/list/?series=437419 > >>>> > >>>> Another prerequisite is my changes to northd. They are not required for > >>>> compilation but to ensure that tests can run: > >>>> https://patchwork.ozlabs.org/project/ovn/list/?series=437305 > >>>> > >>>> Major changes v2->v3: > >>>> * Ensure that we do not try write to non existing sb tables during > >>>> upgrades. > >>>> > >>>> Felix Huettner (8): > >>>> controller: Introduce route node. > >>>> controller: Introduce route-exchange-netlink. > >>>> controller: Announce routes via route-exchange. > >>>> controller: Support learning routes. > >>>> controller: Support learning routes per iface. > >>>> controller: Prioritize host routes. > >>>> controller: Watch for route changes. > >>>> controller: Cleanup routes on stop. > >>> > >>> Isn't a significant chunk of this based on Frode's > >>> https://patchwork.ozlabs.org/project/ovn/list/?series=416659&state=* ? > >>> > >>> Frode, Felix, it would be nice if you guys could have a look and agree > >>> on the proper authorship attributions of these patches. > >>> > >> > >> I did a first full review iteration of this series and shared some > >> comments/findings/questions on each of the individual patches. > >> > >> However, I didn't do full e2e testing yet. I'll try to also review the > >> "OVN Fabric integration: active-active." [0] series before doing more > >> thorough testing. > >> > >> [0] https://patchwork.ozlabs.org/project/ovn/list/?series=437377&state=* > > > > Hi Felix, > > > > For the v4 version, can you possible add a multinode system test(s) > > (in tests/ovn-multinode.at) > > instantiating frr daemons ? > > > > This would help in understanding the feature end-to-end and of course > > to test the functionality end-to-end ? > > > > +1 that's a very good idea! Felix, let me know if you need help with > doing that.
Hi Numan, Hi Dumitru, sounds like a good idea. However i am not sure if i will have the time to actually get this done before the feature freeze for 25.03. I would try to send out v4 as soon as i have it ready and then build this afterwards, just to give reviewers more time. However if anyone else could help out there that would be really great. Thanks a lot, Felix > > Thanks, > Dumitru > > > Thanks > > Numan > > > >> > >> Regards, > >> Dumitru > >> > >> _______________________________________________ > >> dev mailing list > >> d...@openvswitch.org > >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev