On 1/30/25 3:14 PM, Dumitru Ceara wrote: > Hi Felix, > > I just started reviewing this new version of the patchset. One thing it > will need for sure is a rebase. In case it helps I did that here: > > https://github.com/dceara/ovn/commits/tmp-bgp-northd-v4/ > > I'll now review the individual patches closely.
I just finished reviewing this version. From my perspective there's no major issue with it. One thing we still need to decide on is related to potentially consolidating all the route advertising filter options under a single "dynamic-routing-advertised:<list-of-various-type>" or similar. But we can continue that discussion on v5 I guess. I also shared some more comments on the individual patches. I marked the patchset as "changes requested" in patchwork: https://patchwork.ozlabs.org/project/ovn/list/?series=441243&state=* Looking forward to v5! Thanks, Dumitru > > Regards, > Dumitru > > On 1/22/25 12:18 PM, Felix Huettner via dev wrote: >> On Wed, Jan 22, 2025 at 12:04:54PM +0100, [email protected] wrote: >>> Hi Felix, >>> I noticed that `maintain-vrf` was renamed to `dynamic-routing-maintain- >>> vrf` in v4. Are there any other significant changes? >> >> Ah, sorry i missed to list that one here. >> Nothing more that i rembember :) >> >>> >>> Martin. >>> >>> On Tue, 2025-01-21 at 16:47 +0100, Felix Huettner via dev wrote: >>>> Hi everyone, >>>> >>>> this is the northd part of the OVN Fabric integration series >>>> https://mail.openvswitch.org/pipermail/ovs-dev/2024-November/418554.html >>>> . >>>> >>>> By the end of the series northd can announce routes by writing to the >>>> sb Advertised_Route table. >>>> Northd can also learn routes by reading from the sb Learned_Route >>>> table. >>>> >>>> There is a parallel patch series that works on this from the side >>>> of the ovn-controller. >>>> >>>> Since v2 all of the open review comments where addressed and the >>>> series >>>> was rebased. >>>> Since v3 some address sanitizer issues where fixed. >>>> >>>> Felix Huettner (6): >>>> northd: Sync Advertised_Route to sb. >>>> northd: Add filtering which routes to advertise. >>>> northd: Handle learned routes. >>>> northd: Remove learned routes if lrp is removed. >>>> northd: Allow announcing individual host routes. >>>> northd: Sync routing data to pb. >>>> >>>> NEWS | 23 ++ >>>> ic/ovn-ic.c | 21 - >>>> lib/ovn-util.c | 22 ++ >>>> lib/ovn-util.h | 2 + >>>> lib/stopwatch-names.h | 2 + >>>> northd/automake.mk | 4 + >>>> northd/en-advertised-route-sync.c | 395 +++++++++++++++++++ >>>> northd/en-advertised-route-sync.h | 40 ++ >>>> northd/en-learned-route-sync.c | 220 +++++++++++ >>>> northd/en-learned-route-sync.h | 33 ++ >>>> northd/en-lflow.c | 5 +- >>>> northd/en-northd-output.c | 8 + >>>> northd/en-northd-output.h | 2 + >>>> northd/inc-proc-northd.c | 27 +- >>>> northd/northd.c | 367 ++++++++++-------- >>>> northd/northd.h | 99 ++++- >>>> northd/ovn-northd.c | 6 + >>>> ovn-nb.xml | 148 +++++++ >>>> tests/ovn-northd.at | 623 >>>> ++++++++++++++++++++++++++++-- >>>> 19 files changed, 1828 insertions(+), 219 deletions(-) >>>> create mode 100644 northd/en-advertised-route-sync.c >>>> create mode 100644 northd/en-advertised-route-sync.h >>>> create mode 100644 northd/en-learned-route-sync.c >>>> create mode 100644 northd/en-learned-route-sync.h >>>> >>>> >>>> base-commit: 540b324184a55f18ea3c6d98a32e19ad4c3706a6 >>> >>> _______________________________________________ >>> dev mailing list >>> [email protected] >>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> _______________________________________________ >> dev mailing list >> [email protected] >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
