On 2/3/25 2:33 PM, Dumitru Ceara wrote: >> + struct re_nl_received_route_node *rr = xzalloc(sizeof *rr); > Nit: xmalloc() is good enough. >
I see now that in patch 7/11 we implicitly rely on the ifname (added in that patch) to be zeroed. I still think we should keep xmalloc() here and just add the null terminator in the next patch. >> + ovs_list_push_back(handle_data->learned_routes, &rr->list_node); > Nit: I'd push this to the list after it is fully initialized. > >> + rr->db = handle_data->db; >> + rr->addr = rd->rta_dst; >> + rr->plen = rd->rtm_dst_len; >> + rr->nexthop = nexthop->addr; >> + } _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
