On 1/23/25 16:56, David Marchand wrote:
> Rather than drop all pending Tx offloads on recirculation,
> preserve inner offloads (and mark packet with outer Tx offloads)
> when parsing the packet again.
>
> Fixes: c6538b443984 ("dpif-netdev: Fix crash due to tunnel offloading on
> recirculation.")
> Fixes: 084c8087292c ("userspace: Support VXLAN and GENEVE TSO.")
> Signed-off-by: David Marchand <[email protected]>
> ---
> Changes since v1:
> - rebased,
> - dropped API change on miniflow_extract(), rely on tunnel offloading
> flag presence instead,
> - introduced dp_packet_reset_outer_offsets,
>
> ---
> lib/dp-packet.h | 23 +++++++++++------------
> lib/dpif-netdev.c | 27 ---------------------------
> lib/flow.c | 34 ++++++++++++++++++++++++++++------
> 3 files changed, 39 insertions(+), 45 deletions(-)
Hi, David. Thanks for the patch!
Did you run some performance tests with this change? It touches the very
core of packet parsing, so we need to check how that impacts normal V2V or
PVP scenarios even without tunneling.
Best regards, Ilya Maximets.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
