On Wed, Feb 05, 2025 at 02:19:45PM +0100, Dumitru Ceara wrote: > On 2/4/25 2:59 PM, Felix Huettner via dev wrote: > > Here we expand the previous routes-sync engine node to not only > > advertise routes to the southbound table, but also learn received routes > > from this table. > > > > These routes are then passed to the same logic that connected and static > > routes are using for flow generation. > > However we prioritize these routes lower than connected or static routes > > as information in cluster (for the same prefix length) should always be > > more correct then learned routes. > > This is also consistent with the default behaviour of phyiscal routers. > > > > Signed-off-by: Felix Huettner <[email protected]> > > --- > > Hi Felix, > > > v5->v6: > > * addressed review comments > > * changed option to "dynamic-routing-redistribute" > > v4->v5: skipped > > v2->v3: > > * A lot of minor review comments. > > * Support learning routes over other address families > > > > NEWS | 4 + > > lib/stopwatch-names.h | 1 + > > northd/automake.mk | 2 + > > northd/en-ecmp-nexthop.c | 16 +- > > northd/en-learned-route-sync.c | 208 +++++++++++++++++++++++ > > northd/en-learned-route-sync.h | 32 ++++ > > northd/en-lflow.c | 5 +- > > northd/inc-proc-northd.c | 14 +- > > northd/northd.c | 301 ++++++++++++++++++++------------- > > northd/northd.h | 28 ++- > > northd/ovn-northd.c | 1 + > > tests/ovn-northd.at | 253 +++++++++++++++++++++++---- > > 12 files changed, 709 insertions(+), 156 deletions(-) > > create mode 100644 northd/en-learned-route-sync.c > > create mode 100644 northd/en-learned-route-sync.h > > [...] > > > @@ -299,6 +307,10 @@ void inc_proc_northd_init(struct ovsdb_idl_loop *nb, > > engine_add_input(&en_lflow, &en_bfd_sync, NULL); > > engine_add_input(&en_lflow, &en_route_policies, NULL); > > engine_add_input(&en_lflow, &en_routes, NULL); > > + /* XXX: This causes a full lflow recompute on each change to any route. > > + * At least for learned routes we should add incremental processing > > here. > > + * */ > > + engine_add_input(&en_lflow, &en_learned_route_sync, NULL); > > Let's also add a TODO.rst item for this? Let's add a "Dynamic Routing" > section at the end of the TODO file so we have an overview of what needs > to be improved, wdyt? > > With that addressed, feel free to add my ack to v7: > Acked-by: Dumitru Ceara <[email protected]>
Hi Dumitru, thanks a lot for the review. I'll add such a section. Thanks, Felix > > Thanks, > Dumitru > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
