On 2/4/25 3:00 PM, Felix Huettner via dev wrote:
> For each vrf we use we open a netlink watcher.
> This allows us to reconcile on changed route entries from outside
> routing agents.
> 
> Signed-off-by: Felix Huettner <[email protected]>
> ---

Hi Felix,

> v5->v6:
>   * addressed review comments
> 
>  controller/automake.mk               |   7 +-
>  controller/ovn-controller.c          |  51 ++++++-
>  controller/route-exchange.c          |   6 +-
>  controller/route-exchange.h          |   3 +
>  controller/route-table-notify-stub.c |  56 ++++++++
>  controller/route-table-notify.c      | 198 +++++++++++++++++++++++++++
>  controller/route-table-notify.h      |  44 ++++++
>  tests/system-ovn.at                  |   4 -
>  8 files changed, 360 insertions(+), 9 deletions(-)
>  create mode 100644 controller/route-table-notify-stub.c
>  create mode 100644 controller/route-table-notify.c
>  create mode 100644 controller/route-table-notify.h
> 

[...]

> +
> +static void *
> +en_route_table_notify_init(struct engine_node *node OVS_UNUSED,
> +                       struct engine_arg *arg OVS_UNUSED)

Nit: indentation.

With that addressed feel free to add my ack to v7:
Acked-by: Dumitru Ceara <[email protected]>

Thanks,
Dumitru

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to