> This code leaves (what I think is) a very werid race condition in place
> as the dp rules will still be present, so a port ID recycle would cause
> unexpected and bad side effects, depending on the DP used.

As this is Bridge add/del sequence, I doubt if port ID recycle is actually
Possible or not. Although I have tested most of bridge deletion in
combination of running traffic and never see any issue or abnormal
behaviour.

> You mention that you are only using this for your usage of userspace
> datapath, but this change would impact all datapaths, so I don't think
> it can be merged as-is.

I think you are right here, and we can skip flushing only for user space
Datapath type. Let me raise another patch having this comment
addressed.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to