On 10 Feb 2025, at 13:25, Eelco Chaudron wrote:
> On 10 Feb 2025, at 12:59, Ilya Maximets wrote:
>
>> On 2/10/25 11:26, Eelco Chaudron wrote:
>>>
>>>
>>> On 6 Feb 2025, at 12:09, Eelco Chaudron wrote:
>>>
>>>> This series fixes multiple issues reported by Coverity.
>>>>
>>>> v2: - Fix review comments from Ilya.
>>>>
>>>> Eelco Chaudron (7):
>>>> nx-match: Fix potential integer underflow.
>>>> ovs-vsctl: Fix missing ovs_scan() return checks.
>>>> tests: Fix multiple Coverity warnings in test programs.
>>>> ofproto-dpif-ipfix: Add NULL check to dpif_ipfix_set_options().
>>>> ofproto: Fix potential null-ptr dereference in meter_insert_rule().
>>>> ofproto: Fix potential NULL pointer dereference in ofproto_type_xx().
>>>> ofproto-dpif-xlate: Fix memory leak in xlate_generic_encap_action().
>>>>
>>>> lib/nx-match.c | 9 ++++++---
>>>> ofproto/ofproto-dpif-ipfix.c | 2 ++
>>>> ofproto/ofproto-dpif-xlate.c | 3 ++-
>>>> ofproto/ofproto.c | 3 +++
>>>> tests/ovs-vsctl.at | 15 +++++++++++++++
>>>> tests/test-aa.c | 1 +
>>>> tests/test-ccmap.c | 2 +-
>>>> tests/test-ovsdb.c | 10 +++++++---
>>>> tests/test-packets.c | 2 +-
>>>> utilities/ovs-vsctl.c | 25 ++++++++++++++++++++-----
>>>> 10 files changed, 58 insertions(+), 14 deletions(-)
>>>
>>> Thanks Mike for the review! Patches applied to main.
>>
>> Hi. While most of these changes are false-positives, the last patch
>> seems to be fixing a leak in a theoretically reachable case.
>>
>> Do you mind backporting that one down to 3.3?
>
> ACK will do this together with the IPSec fix.
The patch is backported down to 3.3.
Cheers,
Eelco
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
