On Tue, 11 Feb 2025 20:59:24 +0200 Gal Pressman wrote: > > Everything else looks very good, though, yes, I would agree with the > > alignment comments made down-thread. This was "accidentally correct" > > before in the sense that the end of the struct would be padded for > > alignment, but isn't guaranteed to be true with an explicit u8 array. > > The output of "pahole -C struct ip_tunnel_info" before/after should > > answer any questions, though. > > Thanks, I will attach pahole's output in the commit message.
Why not slap an __aligned(sizeof(void *)) or just __aligned(8) on the new option field? That should give us the same behavior as we have today implicitly. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
