On 2/6/25 6:44 PM, Ales Musil wrote:
> When the SB database is disconnected we cannot commit any of the
> MAC bindings. The 'struct mac_binding' remain in the hash map until
> SB is writable again. All mac_binding structures are leaked when
> controller exists before it manages to write them into SB. The same
> problem applies to map of 'struct fdb'. This doesn't cause any issues
> on its own because the controller is exiting anyway, but it can
> trigger test failure with following leak message:
>
> Direct leak of 144 byte(s) in 2 object(s) allocated from:
> 0x4c8d13 in malloc (controller/ovn-controller+0x4c8d13)
> 0x8a5848 in xmalloc__ ovs/lib/util.c:141:15
> 0x8a5848 in xmalloc ovs/lib/util.c:176:12
> 0x6577d5 in mac_binding_add controller/mac-cache.c:167:14
> 0x5db85b in pinctrl_handle_put_mac_binding controller/pinctrl.c:4720:5
> 0x5a3002 in process_packet_in controller/pinctrl.c
> 0x5a3002 in pinctrl_recv controller/pinctrl.c:3872:9
> 0x5a3002 in pinctrl_handler controller/pinctrl.c:3954:17
> 0x8781ec in ovsthread_wrapper ovs/lib/ovs-thread.c:429:12
> 0x4c4ecc in asan_thread_start(void*) asan_interceptors.cpp.o
>
> Fixes: fb96ae36793a ("controller: Merge the mac-cache and mac-learn.")
> Signed-off-by: Ales Musil <[email protected]>
> ---
Thanks, Ales and Ilya (for reviewing v1)!
Applied to main and 24.09.
Regards,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
