On 2/13/25 3:10 PM, Ilya Maximets wrote:
> On 2/13/25 13:34, Dumitru Ceara wrote:
>> With the change in 354d766ca892 ("ovn-controller: Remove monitor all
>> of chassis private.") the documentation of the "ovn-monitor-all"
>> external_id became a bit stale. The Chassis_Private table is always
>> conditionally monitored.
>>
>> Update the documentation to reflect that.
>>
>> While at it, also fix up some more minor issues in the documentation of
>> the flag.
>>
>> Fixes: 3c355e35298b ("ovn-controller.c: Support option "ovn-monitor-all".")
>> Fixes: 354d766ca892 ("ovn-controller: Remove monitor all of chassis
>> private.")
>> Reported-by: Ilya Maximets <[email protected]>
>> Signed-off-by: Dumitru Ceara <[email protected]>
>> ---
>> controller/ovn-controller.8.xml | 11 +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/controller/ovn-controller.8.xml
>> b/controller/ovn-controller.8.xml
>> index a6a6d6f4e3..32f6210523 100644
>> --- a/controller/ovn-controller.8.xml
>> +++ b/controller/ovn-controller.8.xml
>> @@ -117,16 +117,19 @@
>> <dd>
>> <p>
>> A boolean value that tells if <code>ovn-controller</code> should
>> - monitor all records of tables in <var>ovs-database</var>. If
>> - set to <code>false</code>, it will conditionally monitor the
>> records
>> - that is needed in the current chassis.
>> + monitor all records of most tables in the <var>OVN
>> Southbound</var>
>
> Unlike 'ovs-database', the 'OVN Southbound' is not an argument, so shouldn't
> be
> marked as <var>. <code> may be used instead.
>
Good point!
> With that addressed:
>
> Acked-by: Ilya Maximets <[email protected]>
>
Thanks for the review! I made the suggested change and applied the
patch to main, 24.09 and 24.03.
Regards,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
