On 2/13/25 9:37 PM, Frode Nordahl wrote: >> On Thu, 2025-02-13 at 14:45 +0100, Dumitru Ceara wrote: >>> On 2/13/25 2:33 PM, Martin Kalcok wrote: >>>> From: Frode Nordahl <[email protected]> >>>> >>>> While IPv6 and NAT does not ring particularly well together in my >>>> mind, it is a supported feature. >>>> >>>> We need this function to allow them in a subsequent patch adding >>>> host route exchange for NAT addresses. >>>> >>>> Signed-off-by: Frode Nordahl <[email protected]> >>>> Signed-off-by: Martin Kalcok <[email protected]> >>>> --- >>> >>> Hi Martin, Frode, >>> >>> Is this patch still needed? I don't think we use get_nat_addresses() >>> anymore, do we? >>> > > [ edited Martin's likely oversight of doing a top-post to its intended > position ] > > On Thu, Feb 13, 2025 at 3:10 PM <[email protected]> wrote: >> >> I guess technically it's not needed. I carried it over because it's a >> small and potentially useful change. However I also see a point in not >> bloating the code with unused feature, so feel free to drop it. > > This patch was indeed part of the original proposal, and looking > through patch 2-4 it does indeed not appear to be used anymore. > > Mailing lists are good archives for unused ideas, so I see no need to > keep it. Not having to excuse the use of the words "IPv6" and "NAT" in > the same commit message is also a bonus! :)
:) > > Dumitru: Do tell if you want a respin to get rid of it! > It's not really needed, I can easily skip it when merging the patches. Thanks, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
