On 2/13/25 21:24, Ilya Maximets wrote: > 'tcp_flags' are not placed at the beginning of the 64-bit block, so > they have to be padded. Today it is done in a hacky way by pushing > zeroes over the last 32-bits of the arp_tha. When that was written > the miniflow_pad_from_64() didn't exist, but it's better to use it > now instead to avoid confusion. > > 'ct_tp_src/dst' are not actually extracted for IGMP. See the > write_ct_md() function. The pushes are there for the padding purposes, > since 'tp_dst' doesn't end on a 64-bit boundary and so we need to pad > before pushing the IGMP group. Use an explicit padding function > instead to avoid a false impression that IGMP can have non-zero > "ports" in the conntrack tuple. > > This change should not change anything functionally. > > Signed-off-by: Ilya Maximets <[email protected]> > ---
Recheck-request: github-robot _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
