On 2/14/25 10:38 AM, Ales Musil wrote: >>>> + "ct_commit_to_zone(snat);", lflow_ref); >>>> + ovn_lflow_add(lflows, od, S_ROUTER_OUT_SNAT, 10, >>>> + "ip && ct.new && flags.unsnat_not_tracked == 1", >>>> + "ct_commit_to_zone(snat);", lflow_ref); >> Maybe not a real issue but I was thinking that the condition >> "flags.unsnat_not_tracked == 1" is not needed here. If it is ct.new we >> should just commit it because we want to commit all. In the end the outcome >> may be the same but I'd prefer the match condition as concise as possible, >> although not a strong opinion here. >> > I think it makes sense however considering the schedule for release I would > leave it in and I can prepare a follow up and test the effect of this, we > could always accept it as bug fix. Any objections?
Sounds reasonable to me. Regards, Dumitru _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
