On 2/17/25 5:31 PM, Dumitru Ceara wrote:
> On 2/17/25 5:28 PM, Ilya Maximets wrote:
>> On 2/17/25 17:01, Dumitru Ceara wrote:
>>> This reverts commit 354d766ca8924b9ba6ab8f471440bb9ae1b6e341.
>>>
>>> As reported by Ilya this change significantly increased load on
>>> ovsdb-servers running the Southbound database in large scale scenarios
>>> (lots of OVN nodes). That's because ovsdb-server currently cannot use
>>> its JSON cache if not all monitor conditions for a given client are set
>>> to 'true'.
>>>
>>> Until ovsdb-server behavior is changed/fixed we need to also revert the
>>> ovn-controller change. While at it also revert the follow up
>>> documentation change done by 1098d316be57 ("controller: Update
>>> ovn-monitor-all documentation.") and add a comment in the code and a test
>>> to explicitly validate the current behavior.
>>>
>>> Reported-at:
>>> https://mail.openvswitch.org/pipermail/ovs-dev/2025-February/421142.html
>>> Reported-by: Ilya Maximets <[email protected]>
>>> Fixes: 354d766ca892 ("ovn-controller: Remove monitor all of chassis
>>> private.")
>>> Fixes: 1098d316be57 ("controller: Update ovn-monitor-all documentation.")
>>> Signed-off-by: Dumitru Ceara <[email protected]>
>>> ---
>>> controller/ovn-controller.8.xml | 12 ++++------
>>> controller/ovn-controller.c | 39 ++++++++++++++-------------------
>>> tests/ovn-controller.at | 37 +++++++++++++++++--------------
>>> 3 files changed, 41 insertions(+), 47 deletions(-)
>>>
>>> diff --git a/controller/ovn-controller.8.xml
>>> b/controller/ovn-controller.8.xml
>>> index 27ea77fa52..a6a6d6f4e3 100644
>>> --- a/controller/ovn-controller.8.xml
>>> +++ b/controller/ovn-controller.8.xml
>>> @@ -117,20 +117,16 @@
>>> <dd>
>>> <p>
>>> A boolean value that tells if <code>ovn-controller</code> should
>>> - monitor all records of most tables in the
>>> - <code>OVN Southbound</code> database. The only exception is the
>>
>> Should we maybe keep the s/ovs-database/OVN Southbound/ part of the change?
>
> I can, if you wish, then I'll have to do a partial revert of
> 1098d316be57 ("controller: Update ovn-monitor-all documentation.") but
> that's OK.
>
>> (It also seems to be mising an underscore)
>
> We use both forms in the ovn-controller man page, I'm also not sure how
> <code> actually. Anyhow, I can change it to OVN_Southbound.
>
> I'll post a v2.
>
Available at:
https://patchwork.ozlabs.org/project/ovn/patch/[email protected]/
Thanks,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
