On 2/18/25 12:18 PM, Ilya Maximets wrote:
> On 2/17/25 20:55, Dumitru Ceara wrote:
>> This reverts commit 354d766ca8924b9ba6ab8f471440bb9ae1b6e341.
>>
>> As reported by Ilya this change significantly increased load on
>> ovsdb-servers running the Southbound database in large scale scenarios
>> (lots of OVN nodes). That's because ovsdb-server currently cannot use
>> its JSON cache if not all monitor conditions for a given client are set
>> to 'true'.
>>
>> Until ovsdb-server behavior is changed/fixed we need to also revert the
>> ovn-controller change. While at it also partially revert the follow up
>> documentation change done by 1098d316be57 ("controller: Update
>> ovn-monitor-all documentation.") - we keep the part that fixes the
>> reference to the OVN Southbound database. Also add a comment in the code
>> and a test to explicitly validate the current behavior.
>>
>> Reported-at:
>> https://mail.openvswitch.org/pipermail/ovs-dev/2025-February/421142.html
>> Reported-by: Ilya Maximets <[email protected]>
>> Fixes: 354d766ca892 ("ovn-controller: Remove monitor all of chassis
>> private.")
>> Fixes: 1098d316be57 ("controller: Update ovn-monitor-all documentation.")
>> Signed-off-by: Dumitru Ceara <[email protected]>
>> ---
>> V2:
>> - Address Ilya's comment:
>> - keep the fix for the OVN_Southbound database reference in the
>> documentation.
>> - Fix one more instance of <var>OVN Southbound</var> in the same
>> section.
>> ---
>> controller/ovn-controller.8.xml | 19 +++++++---------
>> controller/ovn-controller.c | 39 ++++++++++++++-------------------
>> tests/ovn-controller.at | 37 +++++++++++++++++--------------
>> 3 files changed, 45 insertions(+), 50 deletions(-)
>
> Acked-by: Ilya Maximets <[email protected]>
>
Thanks, Ilya! Applied to main, 25.03, 24.09 and 24.03.
Regards,
Dumitru
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
