On Thu, Feb 20, 2025 at 02:46:13PM +0100, Dumitru Ceara wrote: > On 2/18/25 3:02 PM, Felix Huettner via dev wrote: > > The I+P test for dynamic-routing previously specified if engine nodes > > need to have recomputed and/or computed for a specific change. > > However based on the execution speed of the test some changes may be > > batched together in northd (especially northbound and southbound > > updates). > > > > For nodes where we specified "recompute compute" we sometimes did not > > get a nonzero "compute" value as the changes where handled in a run that > > also recomputed. > > > > However this test should only find out if specific changes are processed > > fully incrementally. As such we only care about 3 potential options: > > * We did a recompute (so no or partial incremental handling) > > * We did no recompute and handled a change incrementally > > * There where no changes > > > > By changing to this test method we avoid the issue above. > > > > Signed-off-by: Felix Huettner <[email protected]> > > --- > > > Hi Felix, > > I assume you meant "flaky". I'm not a native speaker but it seems to me > that "flanky" means something completely different. Otherwise this > patch looks good to me. > > I changed the subject summary to use "flaky" and applied the patch to > main and 25.03.
Thanks a lot. Sorry for the typo :) > > Regards, > Dumitru > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
