On 2/25/25 2:04 PM, martin.kal...@canonical.com wrote:
> On Tue, 2025-02-25 at 00:01 +0100, Dumitru Ceara wrote:
>> It makes more sense to make these static (internal) in the module
>> where
>> they're actually used. They use "public" APIs to add advertised
>> dynamic
>> routes.
>>
>> Fixes: cd4ad2f56179 ("northd: Redistribution of NAT/LB routes.")
>> Signed-off-by: Dumitru Ceara <dce...@redhat.com>
>
> I have no objections to moving these functions out of northd.c, so
> overall this can have Acked-by me. However, since we are at it,
> wouldn't it make sense to also move out the `build_parsed_routes` (and
> related functions), as they too, seem to be only used from `en-
> northd.c`.
>
Good point, I'll move those too in v2.
Thanks,
Dumitru
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
