On 2/6/25 19:44, Mark Michelson wrote: > On 2/6/25 08:42, Ilya Maximets wrote: >> On 2/2/25 20:14, Lorenzo Bianconi wrote: >>> Introduce ipv6_src and ipv6_dst to selection_fields column in >>> Load_Balancer Logical_Router_Static_Route tables in order to properly >>> load-balance IPv6 traffic if these fields are selected in group hash >>> algorithm. >>> >>> Reported-at: https://issues.redhat.com/browse/FDP-1032 >>> Signed-off-by: Lorenzo Bianconi <lorenzo.bianc...@redhat.com> >>> --- >>> Changes in v4: >>> - improve test case >>> - fix documentation and comments >>> Changes in v3: >>> - improve documentation >>> - improve self-tests >>> Changes in v2: >>> - add new load-balancer Dual stack system test >>> --- >>> ovn-nb.ovsschema | 9 +- >>> ovn-nb.xml | 10 +- >>> tests/ovn.at | 6 +- >>> tests/system-ovn.at | 256 +++++++++++++++++++++++++++++++++++++++++++- >>> 4 files changed, 269 insertions(+), 12 deletions(-) >> >> Thanks, Lorenzo, for v4! This change and the test look fnctionally >> correct to me. I left a few small, mostly styling, comments below. >> Not sure if maintainers will want to address those on commit, but >> with them addressed: >> >> Acked-by: Ilya Maximets <i.maxim...@ovn.org> > > I made the suggested changes and pushed this to main.
Hi, Mark, Lorenzo, others. Looking at how the original code is written, it assumed that the selection fields work for IPv6 traffic as well. There was even a test case checking IPv6 load balancing, though incorrectly. Taking that into account, I think, this one should be treated as a bug fix and be backported. There are also existing users like ovn-kubernetes that assumed that IPv6 load balancing works. Backporting schema changes is a bit tricky, sure, but can be done if the schema versions are carefully chosen to not overlap with any existing ones while staying lower than the versions from newer branches. What do you think? Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
