On 2/26/25 11:48 AM, Felix Huettner wrote: > On Wed, Feb 26, 2025 at 11:43:26AM +0100, Dumitru Ceara wrote: >> On 2/26/25 11:40 AM, Felix Huettner wrote: >>> On Tue, Feb 11, 2025 at 03:38:48PM +0100, Dumitru Ceara wrote: >>>> On 2/11/25 9:36 AM, Felix Huettner via dev wrote: >>>>> From: Frode Nordahl <fnord...@ubuntu.com> >>>>> >>>>> Introduce route-exchange-netlink module which implements interface >>>>> for maintaining VRFs [0] and routes through Netlink. >>>>> >>>>> There is a desire to do this without having to (re-)implement >>>>> routing protocol state machines in OVN, and to accomplish this we >>>>> make use of Netlink. >>>>> >>>>> Netlink was chosen because: >>>>> * Its ubiquitous nature with availability on any Linux system as >>>>> as well other platforms. >>>>> * Presence of a very good Netlink library implementation in our >>>>> sibling project and library, Open vSwitch. >>>>> * Popular routing protocol software conveniently already have >>>>> support for redistributing routes to/from Netlink. >>>>> * Support for interacting with Virtual Routing and Forwarding >>>>> domains [0], allowing full isolation between virtual network >>>>> resources defined within OVN and the hosting system while >>>>> retaining access to all system network interfaces. >>>>> >>>>> It is important to note that the purpose of this integration is >>>>> generic exchange of control plane information, while allowing to >>>>> keep the datapath in OVS/OVN, enabling users to leverage its full >>>>> range of user-, kernel- and mixed- space datapath implementations. >>>>> >>>>> 0: https://docs.kernel.org/networking/vrf.html >>>>> >>>>> Acked-by: Dumitru Ceara <dce...@redhat.com> >>>>> Co-Authored-by: Felix Huettner <felix.huettner@stackit.cloud> >>>>> Signed-off-by: Felix Huettner <felix.huettner@stackit.cloud> >>>>> Signed-off-by: Frode Nordahl <fnord...@ubuntu.com> >>>>> --- >>>> >>>> Applied to main, thanks! >>>> >>> >>> Hi everyone, >>> >>> regarding: >>> ``` >>> /* This value is arbitrary but currently unused. >>> * See the kernel rtnetlink UAPI at >>> * >>> https://github.com/torvalds/linux/blob/master/include/uapi/linux/rtnetlink.h >>> * */ >>> #define RTPROT_OVN 84 >>> ``` >>> >>> I just wanted to share that this value has been now claimed upstream and is >>> now part of the net-next tree: >>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=6002850fdfe0b4343136670a9895b6ba4ee3285b >>> >> >> Awesome! Should we change the comment in OVN too? > > We can do that. > > Should we keep the #define as it is right now, or should we wrap in in a > #ifndef? > > My feeling is the ifndef, but i am not sure. >
ifndef sounds good to me. Would it make sense to also add a build time assertion? E.g.: BUILD_ASSERT_DECL(RTPROT_OVN == 84); Or is that too much? Thanks, Dumitru _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
