On 27 Feb 2025, at 12:41, Eelco Chaudron wrote:
> On 26 Feb 2025, at 10:43, Adrian Moreno wrote:
>
>> It increases the chances of events being lost on highly loaded systems.
>
> Thanks for sending out a v2! The patch looks good, but maybe we should tweak
> the commit message a bit, as the current phrasing makes it seem like we are
> increasing the chance. Something like:
>
> Without this patch, the chances of events being lost on highly loaded
> systems increase.
>
> I guess this can be done at commit time if needed. Assuming this gets updated:
>
> Acked-by: Eelco Chaudron <echau...@redhat.com>
Ignore my ACK, I missed the following errors:
utilities/usdt-scripts/dpif_op_nl_monitor.py:95:1: F401 'time' imported but
unused
utilities/usdt-scripts/upcall_cost.py:69:1: F401 'time' imported but unused
utilities/usdt-scripts/upcall_monitor.py:29:80: E501 line too long (80 > 79
characters)
>> Signed-off-by: Adrian Moreno <amore...@redhat.com>
>> ---
>> utilities/usdt-scripts/dpif_op_nl_monitor.py | 1 -
>> utilities/usdt-scripts/upcall_cost.py | 1 -
>> utilities/usdt-scripts/upcall_monitor.py | 2 --
>> 3 files changed, 4 deletions(-)
>>
>> diff --git a/utilities/usdt-scripts/dpif_op_nl_monitor.py
>> b/utilities/usdt-scripts/dpif_op_nl_monitor.py
>> index 22d282328..82ccf6008 100755
>> --- a/utilities/usdt-scripts/dpif_op_nl_monitor.py
>> +++ b/utilities/usdt-scripts/dpif_op_nl_monitor.py
>> @@ -784,7 +784,6 @@ def main():
>> while 1:
>> try:
>> b.ring_buffer_poll()
>> - time.sleep(0.5)
>> except KeyboardInterrupt:
>> break
>>
>> diff --git a/utilities/usdt-scripts/upcall_cost.py
>> b/utilities/usdt-scripts/upcall_cost.py
>> index 765669585..1a3608d5b 100755
>> --- a/utilities/usdt-scripts/upcall_cost.py
>> +++ b/utilities/usdt-scripts/upcall_cost.py
>> @@ -1587,7 +1587,6 @@ def main():
>> b.ring_buffer_poll()
>> if options.stop != 0 and events_received >= options.stop:
>> break
>> - time.sleep(0.5)
>> except KeyboardInterrupt:
>> break
>>
>> diff --git a/utilities/usdt-scripts/upcall_monitor.py
>> b/utilities/usdt-scripts/upcall_monitor.py
>> index d856547f0..3a758b2d2 100755
>> --- a/utilities/usdt-scripts/upcall_monitor.py
>> +++ b/utilities/usdt-scripts/upcall_monitor.py
>> @@ -120,7 +120,6 @@ import psutil
>> import re
>> import struct
>> import sys
>> -import time
>>
>> #
>> # Actual eBPF source code
>> @@ -513,7 +512,6 @@ def main():
>> while 1:
>> try:
>> b.ring_buffer_poll()
>> - time.sleep(0.5)
>> except KeyboardInterrupt:
>> break
>>
>> --
>> 2.48.1
>>
>> _______________________________________________
>> dev mailing list
>> d...@openvswitch.org
>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
