On Thu, Feb 27, 2025 at 12:41:02PM +0100, Dumitru Ceara wrote:
> On 2/26/25 2:00 PM, Felix Huettner via dev wrote:
> > In this series we add support for incremental processing of learned
> > routes. At the end of the series adding or removing learned routes no
> > longer triggers an lflow recompute.
> >
> > Also the logic in here supports other types of routes too. We there
> > however need to add incremental support to the route engine node.
> >
> > Felix Huettner (5):
> > northd: Add en-learned-route-sync I+P handling.
> > northd: Add group ecmp route engine node.
> > northd: Support I+P for group_ecmp_route engine.
> > northd: Add lflow_ref for route entries.
> > northd: Support I+P of lflows on route changes.
> >
>
> Thanks, Felix, for this version! I applied it to main with the
> following minor changes made to the last patch:
>
> diff --git a/northd/en-lflow.c b/northd/en-lflow.c
> index 388e99e1e1..1aac6bc74d 100644
> --- a/northd/en-lflow.c
> +++ b/northd/en-lflow.c
> @@ -309,9 +309,9 @@ lflow_group_ecmp_route_change_handler(struct engine_node
> *node,
> }
>
> /* Now we handle created or updated route nodes. */
> - HMAPX_FOR_EACH (hmapx_node,
> -
> &group_ecmp_route_data->trk_data.crupdated_datapath_routes
> - ) {
> + struct hmapx *crupdated_datapath_routes =
> + &group_ecmp_route_data->trk_data.crupdated_datapath_routes;
> + HMAPX_FOR_EACH (hmapx_node, crupdated_datapath_routes) {
> route_node = hmapx_node->data;
> lflow_ref_unlink_lflows(route_node->lflow_ref);
> build_route_data_flows_for_lrouter(
> diff --git a/TODO.rst b/TODO.rst
> index 6c2b0aa931..e50b1bd76d 100644
> --- a/TODO.rst
> +++ b/TODO.rst
> @@ -143,9 +143,6 @@ OVN To-do List
>
> * Dynamic Routing
>
> - * Add incremental processing for northd when the Learned_Route table
> changes.
> - Currently en_lflow is fully recomputed whenever such a change happens.
> -
> * Add incremental processing of en_dynamic_routes for stateful
> configuration
> changes.
>
> ---
>
> Given that this improves a feature that's only going to be present
> starting with 25.03.0 and that it doesn't affect other functionality
> in any way I also decided to go ahead and backport this to branch-25.03.
Thanks a lot
>
> Best regards,
> Dumitru
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
