Hi Cheng, Cheng Li writes:
> Ovs ko passes odp key and packet to userspace. Next packet is > extracted into flow, which is the input for xlate to generate wc. > At last, ukey(= odp_key/wc) is installed into datapath. If the > odp_key is not consistant with packet extracted flow. The ukey > will be wrong. > > commit [1] was created to fix inconsistance caused by bad tcp > header. commit [2] was cretaed to fix inconsistance caused by bad > ip header. There is no guarantee of the consistance of odp_key and > packet flow. So it is necessary to make the check to prevent from > installing wrong ukey. > > [1] 1f5749c790accd98dbcafdaefc40bf5e52d7c672 > [2] 79349cbab0b2a755140eedb91833ad2760520a83 > > Signed-off-by: Cheng Li <lic...@chinatelecom.cn> > --- We don't generally rely on the kernel ODP parsing, and this would create a situation where any kind of kernel / userspace mismatch would end up in incredibly poor performance. The two commits referenced are really parsing bugs in the userspace, and they need fixing regardless of whether userspace ignores or incorporates details from the provided kernel key. Did I miss something here? _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
