On 2/27/25 3:28 PM, Dumitru Ceara wrote:
> On 2/27/25 2:35 PM, Martin Kalcok wrote:
>> Experiemntal tags are removed from LRP options "routing-protocol-redirect" 
>> and
>> "routing-protocols".
>>
>> Signed-off-by: Martin Kalcok <[email protected]>
>> ---
> 
> Hi Martin,
> 
> Thanks for the patch!
> 
>>  NEWS       | 7 +++++--
>>  ovn-nb.xml | 8 --------
>>  2 files changed, 5 insertions(+), 10 deletions(-)
>>
>> diff --git a/NEWS b/NEWS
>> index d1767e5b3..192532837 100644
>> --- a/NEWS
>> +++ b/NEWS
>> @@ -11,8 +11,8 @@ OVN v25.03.0 - xx xxx xxxx
>>       removed in the next release.
>>     - The LRP option 'centralize_routing' has been removed. The behavior is 
>> now
>>       enabled in all cases where it is needed.
>> -   - The experimental logical router port options 
>> "routing-protocol-redirect"
>> -     and "routing-protocols" are now also usable on distributed gateway 
>> ports.
>> +   - The logical router port options "routing-protocol-redirect" and
>> +     "routing-protocols" are now also usable on distributed gateway ports.
> 
> Nit: we could move this down in the "Dynamic Routing" section.
> 
>>     - ovn-nb: Changed schema of ovn-nb to make networks optional within 
>> Logical
>>       Router Ports.
>>     - Added support for Spine-Leaf topology of logical switches by adding
>> @@ -83,6 +83,9 @@ OVN v25.03.0 - xx xxx xxxx
>>         interface names using "dynamic-routing-port-mapping".
>>     - Add "options:ct-commit-all" to LR, that enables commit of all traffic
>>       to DNAT and SNAT zone when LR is stateful.
>> +   - Logical router port options "routing-protocol-redirect" and
>> +     "routing-protocols" are now considered stable. Their "experimental" tag
>> +     was removed.
> 
> Nit: we could move this down in the "Dynamic Routing" section.
> 
> With these addressed:
> Acked-by: Dumitru Ceara <[email protected]>
> 

I just realized I might have not been too clear above, sorry.  I have
already marked the series as "Changes Requested" in patchwork.

https://patchwork.ozlabs.org/project/ovn/list/?series=446314&state=*

Feel free to add my ack to v3 if these are the only changes you make.

Thanks,
Dumitru

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to